Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcpe 0.16 support 'varint' #15

Closed
ghost opened this issue Oct 30, 2016 · 5 comments · Fixed by #35
Closed

mcpe 0.16 support 'varint' #15

ghost opened this issue Oct 30, 2016 · 5 comments · Fixed by #35

Comments

@ghost
Copy link

ghost commented Oct 30, 2016

<gurun> talked to mojang today. The NBT for items, chunks and other stuff is a mess right now, even for them. They ARE moving towards all of it going over the wire to be VarInt style, but right now .. it's totally a mix. ​

I present you, the new specification!
varint is always little-endian (finally they can settle on something)
we also need varlong, I don't think ProtoDef has that

Here is an implementation in C# NiclasOlofsson/fNbt@61619ac
Strings are varint prefixed, and there can be varint32 and varint64 fields it looks like

  • All ints are now replaced with varints
  • We will need to actually separate the implementations
@rom1504
Copy link
Member

rom1504 commented Nov 2, 2016

feel free to start writing a .json for this.
Once it can decode mcpe nbt properly, we'll see how to integrate it properly here. (Would be useful to have some mcpe nbt example files !)

@ghost
Copy link
Author

ghost commented Nov 2, 2016

Ah yeah, I'll ask around and see if I can grab a 0.16 NBT file, or if I can generate one myself

@rom1504
Copy link
Member

rom1504 commented Dec 13, 2016

would be useful to put infos here

  • link to nbt example
  • description of the new format

@ghost
Copy link
Author

ghost commented Dec 14, 2016

#18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant