-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chart-testing via github actions #21
Conversation
Makes sense to keep it all in one place. If I understand Github actions and our TravisCI setup correctly, you would need to replicate the below into a ruby based Github action? Lines 1 to 19 in cbdf928
Like this one, maybe? https://github.com/helm/chart-releaser-action |
@elrido Yes, i'm looking to use the chart-releaser-action to replace our current setup. I need to research migrating the existing content to make sure we don't lose any historical versions (in case they are in use). I'm hoping to get to it over the weekend. For now I wanted to add the chart-testing since I switched to it on some work projects and it's working well. |
@elrido how do you feel about getting this merged before we migrate the chart releaser part, to catch things like version change requirements as we update the chart? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, lets set this up!
Test the privatebin-helm chart the same way the core helm charts are tested.
I'd like to think about moving to github actions for deploying the helm repo to github pages as well.