Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chart-testing via github actions #21

Merged
merged 7 commits into from
Jun 25, 2020
Merged

Add chart-testing via github actions #21

merged 7 commits into from
Jun 25, 2020

Conversation

bdashrad
Copy link
Collaborator

@bdashrad bdashrad commented Mar 11, 2020

Test the privatebin-helm chart the same way the core helm charts are tested.

I'd like to think about moving to github actions for deploying the helm repo to github pages as well.

@bdashrad bdashrad added the enhancement New feature or request label Mar 11, 2020
@elrido
Copy link
Contributor

elrido commented Mar 11, 2020

Makes sense to keep it all in one place. If I understand Github actions and our TravisCI setup correctly, you would need to replicate the below into a ruby based Github action?

helm-chart/.travis.yml

Lines 1 to 19 in cbdf928

---
language: ruby
before_install:
- curl https://raw.githubusercontent.com/kubernetes/helm/master/scripts/get > get_helm.sh
- sudo bash ./get_helm.sh
- helm version --client
- helm init --client-only
script:
- rake package
- rake clone
- rake index
deploy:
- provider: pages
skip_cleanup: true
github_token: $GITHUB_TOKEN
keep_history: true
local_dir: docs
on:
branch: master

Like this one, maybe? https://github.com/helm/chart-releaser-action

@bdashrad
Copy link
Collaborator Author

@elrido Yes, i'm looking to use the chart-releaser-action to replace our current setup. I need to research migrating the existing content to make sure we don't lose any historical versions (in case they are in use). I'm hoping to get to it over the weekend. For now I wanted to add the chart-testing since I switched to it on some work projects and it's working well.

@bdashrad
Copy link
Collaborator Author

@elrido how do you feel about getting this merged before we migrate the chart releaser part, to catch things like version change requirements as we update the chart?

Copy link
Contributor

@elrido elrido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, lets set this up!

@elrido elrido merged commit 2670577 into master Jun 25, 2020
@bdashrad bdashrad deleted the chart-testing branch June 25, 2020 15:32
@github-actions github-actions bot mentioned this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants