Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service account option #29

Merged
merged 3 commits into from
Sep 22, 2020

Conversation

cnellis101
Copy link
Contributor

@cnellis101 cnellis101 commented Sep 18, 2020

The chart does not support the use of service accounts. This feature is needed is some security contexts where API access to these resources may need to be limited.

I've set the default for .Values.serviceAccount.create to false to prevent any migration issues for other users. Also, it will use the service account default on new installs just like it does now when set to false.

Copy link
Collaborator

@bdashrad bdashrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but update the minor version number instead since we're adding features.

privatebin/Chart.yaml Outdated Show resolved Hide resolved
Co-authored-by: Brad Clark <bdashrad@gmail.com>
@bdashrad bdashrad merged commit e7c0326 into PrivateBin:master Sep 22, 2020
@jj0b
Copy link

jj0b commented Sep 22, 2020

@quizy101

Since this was merged today ArgoCD is no longer able to sync privatebin in my cluster.

GROUP  KIND        NAMESPACE   NAME                STATUS     HEALTH   HOOK  MESSAGE
apps   Deployment  privatebin  privatebin          OutOfSync  Missing        error validating data: ValidationError(Deployment.spec): unknown field "serviceAccountName" in io.k8s.api.apps.v1.DeploymentSpec

Is there something I need to update to accommodate this change?

@cnellis101 cnellis101 mentioned this pull request Sep 23, 2020
@cnellis101
Copy link
Contributor Author

@jj0b I have a fix at #30 hopefully these changes can get merged quickly. Sorry for the confusion.

@jj0b
Copy link

jj0b commented Sep 23, 2020

@quizy101 no worries. Thanks!

@jj0b
Copy link

jj0b commented Sep 23, 2020

@quizy101 confirmed working. :-) Cheers!

@cnellis101 cnellis101 deleted the add-service-account-option branch September 24, 2020 15:06
@github-actions github-actions bot mentioned this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants