-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service account option #29
Add service account option #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but update the minor version number instead since we're adding features.
Co-authored-by: Brad Clark <bdashrad@gmail.com>
@quizy101 Since this was merged today ArgoCD is no longer able to sync privatebin in my cluster.
Is there something I need to update to accommodate this change? |
@quizy101 no worries. Thanks! |
@quizy101 confirmed working. :-) Cheers! |
The chart does not support the use of service accounts. This feature is needed is some security contexts where API access to these resources may need to be limited.
I've set the default for
.Values.serviceAccount.create
tofalse
to prevent any migration issues for other users. Also, it will use the service accountdefault
on new installs just like it does now when set tofalse
.