Add v1 ingress support #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The error reported by the chart linter is:
|
|
@rlex if you bump the chart version to 0.9.0 this should pass linting. https://github.com/PrivateBin/helm-chart/blob/master/charts/privatebin/Chart.yaml#L8 |
|
Since kubernetes 1.18 is already EOL, i'd prefer to only make this change to support 1.19+. People on <1.19 can use the older chart or upgrade. |
|
This PR should handle both pre-v1.22 k8s and v1.22+ with v1 ingress api, so users shouldn't have any issues with recent versions. Theoretically. I do not have older cluster to check. When v1 became available? 1.19? |
|
seems to be passing now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #47
Better check on 1.21 and lower, since i only tested it on 1.22