fix pyproj version #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OscarOnTrack
requested review from
PR-Maik,
JoostProRail,
oscarvhees and
luukschuurmansprorail
as code owners
|
The code quality checks have failed; one test failed. I checked locally and it does still seem to work on my local Windows setup (which is setup using the 'old' README). |
JoostProRail
requested changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyproj < 3 did not work for Apple devices (with M1 chip), and the package works on Windows without this requirement. Furthermore, the <3 version requirement in setup.py is inconsistent with the 3.3.* requirements in requirements.txt, so it makes sense to remove the <3 requirement in setup.py