New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make plottable objects more consistent #36

Closed

JoostProRail opened this issue Aug 16, 2022 · 0 comments · Fixed by #35

Collaborator

JoostProRail commented Aug 16, 2022 •

edited

In particular:

Base all 3 objects on a GeoDataFrame under self.data. PlottingPoints will require the most work here.
Fix the popup argument in a consistent manner (none, str or tuple of strings)
- Fix the data argument in a consistent manner (string or geopandas geodataframe)
General support for self.color?

Additionally, if possible we can try to make PlottingPoints work for pandas dataframes too.

JoostProRail linked a pull request

that will close this issue

Add plottingarea #35

Merged

JoostProRail closed this as completed in #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment