New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spoortakmodel #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that the datasets are included. One concern might be that the repository might become a bit big (the review of the changes was hard to do as git couldn't load all the files) and all the data files will show up in the git log from now on.
It might be preferable to host the data files in some other location, but I agree that this is sufficient for now (also I wouldn't know how to best approach this in the first place).
Approved!
|
Added a mapping and inspection classes to work with spoortak model version 3 up to and including version 17
Note the spoortak models data has not yet been included. We are verifying if they can be distributed or not trough github.
Thus the integration tests will fail due to missing data.