Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spoortakmodel #8

Merged
merged 7 commits into from May 6, 2022
Merged

Spoortakmodel #8

merged 7 commits into from May 6, 2022

Conversation

Nozziel
Copy link
Collaborator

@Nozziel Nozziel commented Mar 18, 2022

Added a mapping and inspection classes to work with spoortak model version 3 up to and including version 17

Note the spoortak models data has not yet been included. We are verifying if they can be distributed or not trough github.
Thus the integration tests will fail due to missing data.

JoostProRail
JoostProRail previously approved these changes Apr 22, 2022
Copy link
Collaborator

@JoostProRail JoostProRail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small comments.

openspoor/spoortakmodel/spoortak_models_data.py Outdated Show resolved Hide resolved
data/readme.md Outdated Show resolved Hide resolved
openspoor/spoortakmodel/spoortak_model_inspector.py Outdated Show resolved Hide resolved
openspoor/spoortakmodel/spoortak_models_data.py Outdated Show resolved Hide resolved
openspoor/spoortakmodel/spoortak_models_data.py Outdated Show resolved Hide resolved
@Nozziel Nozziel requested a review from JoostProRail May 4, 2022 13:47
Copy link
Collaborator

@JoostProRail JoostProRail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that the datasets are included. One concern might be that the repository might become a bit big (the review of the changes was hard to do as git couldn't load all the files) and all the data files will show up in the git log from now on.
It might be preferable to host the data files in some other location, but I agree that this is sufficient for now (also I wouldn't know how to best approach this in the first place).
Approved!

@Nozziel
Copy link
Collaborator Author

Nozziel commented May 4, 2022

It might be preferable to host the data files in some other location,...
Yeah, I've already created an issue for this #23 so we can discuss what we want to do with static data files goin forward.
for there are already 2 files that could not be added due to their sizes (currently they are also not needed)

@Nozziel Nozziel merged commit 6e9e309 into ProRail-DataLab:main May 6, 2022
@Nozziel Nozziel deleted the spoortakmodel branch May 6, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants