Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todo!() and unimplemented!() are not legacy in rust #13

Closed
Hasenn opened this issue Feb 26, 2021 · 2 comments
Closed

todo!() and unimplemented!() are not legacy in rust #13

Hasenn opened this issue Feb 26, 2021 · 2 comments

Comments

@Hasenn
Copy link

Hasenn commented Feb 26, 2021

the readme seems to suggest that they are, and the legacy mode really shouldn't exist

@Hasenn
Copy link
Author

Hasenn commented Feb 26, 2021

Moreover, unimplemented!() is not a todo
rust doc says :

"The difference between unimplemented! and todo! is that while todo! conveys an intent of implementing the functionality later and the message is "not yet implemented", unimplemented! makes no such claims. Its message is "not implemented". Also some IDEs will mark todo!s."

@ProbablyClem
Copy link
Owner

The legacy mode doesn't imply that todo!() and unimplemented!() are legacy within the std.
It's for a project that's already written and where you don't want to rewrite all your todos with the cargo-todo info (member, priority, ...).
If you're starting a project from scratch, you'd better use them, but most of the time you don't write to spend times on formating older todos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants