Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a class to manage simulation inputs #232

Open
1 task
yakutovicha opened this issue Nov 10, 2023 · 0 comments · May be fixed by #275
Open
1 task

Create a class to manage simulation inputs #232

yakutovicha opened this issue Nov 10, 2023 · 0 comments · May be fixed by #275
Assignees

Comments

@yakutovicha
Copy link
Collaborator

yakutovicha commented Nov 10, 2023

Currently, all the input parameters are stored in the params variable of the common.py module. The problem with this approach is that there is only one instance of the module, so one cannot keep running multiple simulations as they might require different inputs.

So, I suggest migrating input configuration into a class and handling things there.

Ideally, after this is implemented the test tests/_test_vdw.py can be re-enabled and everything should pass.

  • Move the default params.ini file from the ppafm/defaults/ folder to the wiki to give people an idea of what it looks like.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant