Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort out flaky unit tests #119

Closed
1 of 5 tasks
danthorpe opened this issue Dec 4, 2015 · 2 comments
Closed
1 of 5 tasks

Sort out flaky unit tests #119

danthorpe opened this issue Dec 4, 2015 · 2 comments

Comments

@danthorpe
Copy link
Member

There are a few unit tests which often seem to be the ones which fail randomly.

  • ReverseGeocoderTests - test__reverse_geocode_starts_geocoder
  • GroupOperationTests - test__group_operations_are_performed_in_order
  • BlockOperationTests - test__that_block_operation_with_no_block_finishes_immediately
  • GatedOperation - test__when_gate_is_closed_operation_is_not_performed
  • Logging - there is actually a bug where the LoggingObserverTests meets LoggingTests.
@danthorpe danthorpe mentioned this issue Dec 11, 2015
Closed
@danthorpe danthorpe modified the milestone: 2.5.0 Dec 11, 2015
@danthorpe danthorpe mentioned this issue Dec 14, 2015
Closed
@danthorpe
Copy link
Member Author

Seems as though many of these tests are now not failing at all thanks to recent bug fixes. Still seen a failure with location though. Will continue to monitor it.

@danthorpe danthorpe removed this from the 2.5.0 milestone Dec 16, 2015
@danthorpe
Copy link
Member Author

Gonna close this now as none of these unit tests are being flaky anymore. I think the various bug fixes in 2.5 have resolved them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danthorpe