Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHEx Mv3 (WE DID IT BOYS) #53

Merged
merged 103 commits into from Aug 7, 2022
Merged

PHEx Mv3 (WE DID IT BOYS) #53

merged 103 commits into from Aug 7, 2022

Conversation

donaldli2020
Copy link
Contributor

@donaldli2020 donaldli2020 commented May 31, 2022

COMPLETE on August 7, 2022.

  • Fix the fucking CSP removal
  • Does it work? Well we had to do something else.
  • Fix the fucking script injection
  • Does it work???
  • Once CSP removal is done then add the redirect for** /load-game.min.js Alternative found
  • Does it work? Yes, we just use HTML IDs to change the splash screen text.:
  • Fix the script. (DONE by afkvido)
  • Remove the file ./.github/workflows/removeonmerge.yml.
  • cleanup

Does this look good?

Releasing

First we wait until the Alphas have checked the boxes.

  • Sign the CRX
  • Make a release on GitHub Releases
  • Make a release on the Microsoft Addons Store - WAITING
  • Make a release on the Mozilla Addons Store - MOZILLA DOESN'T SUPPORT MANIFEST V2
  • Make a release on the Chrome Web Store - WAITING
  • Make a release on the Opera Addons Store - REJECTED

@donaldli2020 donaldli2020 linked an issue May 31, 2022 that may be closed by this pull request
2 tasks
@Erisfiregamer1 Erisfiregamer1 marked this pull request as draft May 31, 2022 11:40
@donaldli2020
Copy link
Contributor Author

  • Remotely hosted code is no longer allowed; an extension can only execute JavaScript that is included within its package.

this is big

@ProdigyPNP ProdigyPNP locked and limited conversation to collaborators May 31, 2022
@afkvido afkvido added Priority: Medium Somewhat important. Category: PHEx Prodigy Hacking Extension Official Formal or official post by a maintainer of ProdigyPNP. labels May 31, 2022
@afkvido afkvido added this to the 2.1.10 milestone Jun 1, 2022
This took me 3 collective hours of research, coding, and getting the fucking thing to work.

And yes, I signed the CRX.
@afkvido
Copy link
Contributor

afkvido commented Jun 10, 2022

7f352a2

MV3 - At least we can block Prodigy's code!

This took me 3 collective hours of research, coding, and getting the fucking thing to work.

And yes, I signed the CRX.

@afkvido
Copy link
Contributor

afkvido commented Jun 10, 2022

Remotely hosted code is no longer allowed; an extension can only execute JavaScript that is included within its package.

I'm pretty sure that the migration guide said that we can still use fetch() every now and then.

@afkvido afkvido changed the title MV3 - DO NOT MERGE PHEx MV3 (Do not merge) Jun 11, 2022
@Erisfiregamer1 Erisfiregamer1 linked an issue Jun 15, 2022 that may be closed by this pull request
4 tasks
@Erisfiregamer1
Copy link
Contributor

Created a tracking issue. Also, updated to base branch.

@Erisfiregamer1
Copy link
Contributor

I'm going to figure out some way to load the game.min.js file from PHEx so we don't have to deal with P-NP or any derivative. This would probably break Infinite Zero, though.

@afkvido
Copy link
Contributor

afkvido commented Aug 5, 2022

@Erisfiregamer1 I was confused when using ProdigyX's method of document events... kinda made me to decide "fuck this, i won't bother".

@afkvido
Copy link
Contributor

afkvido commented Aug 5, 2022

can we remove DeepScan?

bet

I turned off code quality checking which should stop unused variables from being reported, but generic errors will still be reported.

@Erisfiregamer1
Copy link
Contributor

k

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@afkvido
Copy link
Contributor

afkvido commented Aug 5, 2022

This would be a legit error, except it's an extension, so no.

Anyway that one I'll find a way to circumvent

afkvido and others added 6 commits August 7, 2022 15:39
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: gemsvidø <gemsvido@gmail.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@afkvido afkvido marked this pull request as ready for review August 7, 2022 22:49
@afkvido afkvido changed the title !!! PHEx Mv3 (Do not merge) !!! PHEx Mv3 (Awaiting review and final touches) Aug 7, 2022
@afkvido
Copy link
Contributor

afkvido commented Aug 7, 2022

Test it yourselves, BUT FUCK YEEEAHHHH IT WORKS!!!!

@Erisfiregamer1
Copy link
Contributor

Let me test it. WAIT FOR MY REVIEW.

@afkvido
Copy link
Contributor

afkvido commented Aug 7, 2022

BET

Copy link
Contributor

@Erisfiregamer1 Erisfiregamer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. My. God.
After all these months, after ALL THE FUCKING SUFFERING, after hosted's help... we've done it. MV3 is functioning.
Special thanks to:

  • hostedposted, for helping us a lot
  • Svido for finally getting it to work and also doing their best to finish it
  • Everyone else who contributed.

I refuse to wait. LGTM

@afkvido
Copy link
Contributor

afkvido commented Aug 7, 2022

FUCK YEAH!!!!!!

@Erisfiregamer1 Erisfiregamer1 merged commit 821a061 into master Aug 7, 2022
@Erisfiregamer1 Erisfiregamer1 deleted the dev branch August 7, 2022 23:19
@afkvido
Copy link
Contributor

afkvido commented Aug 7, 2022

WOOOOo

@afkvido
Copy link
Contributor

afkvido commented Aug 7, 2022

I'll start signing, releasing, etc.

@Erisfiregamer1
Copy link
Contributor

You do that- I'll ensure that the P-NP servers on my network stay updated if need be.
DAMNIT so much work went into this. THANK GOD it's over.

@afkvido
Copy link
Contributor

afkvido commented Aug 7, 2022

BET BROTHER

Copy link
Contributor

@Erisfiregamer1 Erisfiregamer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't I think of this? (commit: THIS WORKED ONG)

@afkvido
Copy link
Contributor

afkvido commented Aug 8, 2022

xd

@afkvido afkvido changed the title !!! PHEx Mv3 (Awaiting review and final touches) PHEx Mv3 (WE DID IT BOYS) Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: PHEx Prodigy Hacking Extension Official Formal or official post by a maintainer of ProdigyPNP. Priority: High Very important.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

!!! PHEx MV3 tracking issue PHEx MV3
4 participants