Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tesseract stack different items with same id #148

Closed
ybw0014 opened this issue May 22, 2022 · 1 comment
Closed

Tesseract stack different items with same id #148

ybw0014 opened this issue May 22, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@ybw0014
Copy link

ybw0014 commented May 22, 2022

Description (Required)

Using Tesseract to transfer items, it can stack items with same id and lore, but they are actually different items.
This situation is similar to Slimefun/Slimefun4#3379 but I've looked at the code, tesseract uses dough's utils to compare items, which doesn't compare pdcs so items cam be stacked.

The tested items that are affected: Infinty Storage, Network Quantum Storage.

Steps to reproduce the Issue (Required)

  1. Setting up a pair of tesseract. 1 and 2.
  2. Get a barrel, and put items in it, we label it as Barrel A.
  3. Get a barrel, put nothing in it, we lavel it as Barrel B.
  4. Put Barrel A in Tesseract 1's output slot.
  5. Put Barrel B in Tesseract 2's input slot.
  6. The Barrel A's amount increases.

Expected behavior (Required)

Tesseract can distinguish items with same id and lore but different pdcs.

Server Log / Error Report

Environment (Required)

  • Minecraft Version: 1.18.2
  • CS-CoreLib Version:
  • Slimefun Version: 1014
  • Plugin Version: 165
@ybw0014 ybw0014 added the bug Something isn't working label May 22, 2022
@ybw0014
Copy link
Author

ybw0014 commented Jan 17, 2023

This is already resolved in dough, closing it now.

@ybw0014 ybw0014 closed this as completed Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant