Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMW pagewidget result format not working #346

Closed
krabina opened this issue Sep 15, 2022 · 3 comments
Closed

SMW pagewidget result format not working #346

krabina opened this issue Sep 15, 2022 · 3 comments

Comments

@krabina
Copy link

krabina commented Sep 15, 2022

The pagewidget result format of SRF is working with vector skin, but not with chameleon, see
SemanticMediaWiki/SemanticResultFormats#724

Uncaught TypeError: No method named ".slide" Carousel carousel.js:531 jQuery 2 _jQueryInterface carousel.js:506 <anonymous> ext.srf.pagewidget.carousel.js:58 jQuery 2 <anonymous> ext.srf.pagewidget.carousel.js:57 jQuery 2 <anonymous> ext.srf.pagewidget.carousel.js:46 jQuery 2 [carousel.js:531:16](extensions/Bootstrap/resources/bootstrap/src/carousel.js) Carousel carousel.js:531 jQuery 2 _jQueryInterface carousel.js:506 <anonymous> ext.srf.pagewidget.carousel.js:58 jQuery 2 <anonymous> ext.srf.pagewidget.carousel.js:57 jQuery 2 <anonymous> ext.srf.pagewidget.carousel.js:46 jQuery 2

@malberts
Copy link
Contributor

I suspect this is because both SRF and Bootstrap have a carousel component and their JavaScript interfaces are similar. It looks like the wrong one is getting created here.

If my assumption is correct, then I think it might make more sense to change/fix this in SRF (i.e. change the JavaScript class/function name slightly), since SRF's JavaScript is self-contained.
Changing it in Chameleon/Bootstrap is going to require changing upstream Bootstrap. Even if it's possible to change the loading order in Chameleon/Bootstrap, it's still going to be a problem if you somehow have both SRF and Bootstrap carousels on the same page.

@krabina
Copy link
Author

krabina commented Sep 16, 2022

I agree, It should be changed in SRF. Would be great if you could find the time to do it :-)

@malberts
Copy link
Contributor

Fixed in SRF: SemanticMediaWiki/SemanticResultFormats#727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants