add <script fundme> throw logic if MIME type not json

totorogendut · Mar 27, 2020 · dd23a44 · dd23a44
1 parent 6169853
commit dd23a44
Show file tree

Hide file tree

Showing 13 changed files with 49 additions and 5 deletions.
diff --git a/RELEASE.md b/RELEASE.md
@@ -3,6 +3,8 @@
 ## unreleased
 
 - Add examples for using fundme.js in the browser.
+- Now `<script fundme>` will throw an error if its type not `application/json`.
+- Test: add test for `<script fundme>` type.
 
 ## 0.0.3
 

diff --git a/dist/fundme-amd.js b/dist/fundme-amd.js
@@ -53,6 +53,7 @@ define(['exports'], function (exports) { 'use strict';
   // script json template
   const cannotParseScriptJson = 'Fundme.js: cannot parse JSON from <script fundme>. Make sure it contains a valid JSON.';
   const jsonTemplateIsNotArray = "Fundme.js: found <script fundme> but it's not an array.";
+  const scriptFundmeIsNotApplicationJson = 'Fundme.js: found <script fundme> but its type is not "application/json"';
 
   const DEFAULT_WEIGHT = 5;
   // TODO check pointer.address with RegEx
@@ -144,6 +145,9 @@ define(['exports'], function (exports) { 'use strict';
       catch (err) {
           throw new Error(cannotParseScriptJson);
       }
+      if (json.type !== 'application/json') {
+          throw new Error(scriptFundmeIsNotApplicationJson);
+      }
       if (Array.isArray(pointers)) {
           pointers = createPool(pointers);
       }

diff --git a/dist/fundme-amd.min.js b/dist/fundme-amd.min.js
diff --git a/dist/fundme-cjs-compat.min.js b/dist/fundme-cjs-compat.min.js
diff --git a/dist/fundme-cjs.js b/dist/fundme-cjs.js
@@ -55,6 +55,7 @@ const failParsingTemplate = 'Fundme.js: fails to parse address from <template da
 // script json template
 const cannotParseScriptJson = 'Fundme.js: cannot parse JSON from <script fundme>. Make sure it contains a valid JSON.';
 const jsonTemplateIsNotArray = "Fundme.js: found <script fundme> but it's not an array.";
+const scriptFundmeIsNotApplicationJson = 'Fundme.js: found <script fundme> but its type is not "application/json"';
 
 const DEFAULT_WEIGHT = 5;
 // TODO check pointer.address with RegEx
@@ -146,6 +147,9 @@ function parseScriptJson(json) {
     catch (err) {
         throw new Error(cannotParseScriptJson);
     }
+    if (json.type !== 'application/json') {
+        throw new Error(scriptFundmeIsNotApplicationJson);
+    }
     if (Array.isArray(pointers)) {
         pointers = createPool(pointers);
     }