Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assertError() doesn't work properly if reply.showsimplesyntax is set to True #981

Closed
jlu5 opened this issue Jan 1, 2015 · 2 comments
Closed

Comments

@jlu5
Copy link
Collaborator

jlu5 commented Jan 1, 2015

I decided to spin up a custom mod of Limnoria a while ago, with custom defaults in src/conf.py. One of these includes setting reply.showsimplesyntax to True by default, but this causes many tests to fail on assertError!

Although this isn't currently an issue in stock Limnoria (showsimplesyntax is disabled by default), a config option should not cause unrelated tests to fail.

A snippet from $ supybot-test Conditional/:

FAIL: testNne (Conditional.test.ConditionalTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/gl/.local/lib/python3.4/site-packages/supybot/test.py", line 154, in runTest
    originalRunTest()
  File "./Conditional/test.py", line 114, in testNne
    self.assertError('nne 1 2 3')
  File "/home/gl/.local/lib/python3.4/site-packages/supybot/test.py", line 282, in assertError
    '%r did not error: %s' % (query, m.args[1]))
AssertionError: False is not true : 'nne 1 2 3' did not error: nne <item1> <item2>

----------------------------------------------------------------------
Ran 17 tests in 6.474s

FAILED (failures=7)
@progval
Copy link
Owner

progval commented Nov 2, 2019

I don't think it's a bug, lots of tests would break with non-default configs (eg. not replying on error, replying with notices, etc.)

@jlu5
Copy link
Collaborator Author

jlu5 commented Nov 3, 2019

Yeah, let's close this as wontfix since my previous use-case for this issue is no longer there.

@jlu5 jlu5 closed this as completed Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants