Skip to content
This repository has been archived by the owner on Feb 23, 2022. It is now read-only.

Drop unique requirement for template_id column in letter_versions table #183

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

JamesMGreene
Copy link
Contributor

Ran into some unexpected migration failures when running #147 against the production database. 😖

@JamesMGreene JamesMGreene requested a review from a team as a code owner February 1, 2022 18:03
@JamesMGreene JamesMGreene merged commit 7236a77 into main Feb 1, 2022
@JamesMGreene JamesMGreene deleted the non-unique-template-id branch February 1, 2022 18:04
@JamesMGreene
Copy link
Contributor Author

P.S. Props to @nawazkhan for suggesting I remove this in #147. I should've checked the production data more carefully. 😓

@JamesMGreene
Copy link
Contributor Author

For posterity, this was the associated deployment failure (slightly scrubbed):

       migration file "20211230165827_harden-letter_versions-table.js" failed
       migration failed with error: alter table "letter_versions" add constraint "letter_versions_template_id_unique" unique ("template_id") - could not create unique index "letter_versions_template_id_unique"
alter table "letter_versions" add constraint "letter_versions_template_id_unique" unique ("template_id") - could not create unique index "letter_versions_template_id_unique"
Key (template_id)=(tmpl_idHasBeenScrubbedHere) is duplicated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant