-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/ahn nath: Add social media icons with links to representative card #361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahn-nath Looks good to me, Nath. I appreciate the clean and organized implementation you've done, especially with the separation of concerns and maintaining the code style.
Have you tested it out on some zip codes? If so, could you share some screenshots of what it looks like? It would help ensure the results are consistent with the proposed UI.
Hi, Param. Thanks. Yes, I have tested it several times, normally, with zip codes corresponding to Washington. I cannot upload a screenshot since I have internet connection issues right now, and it prevents me from connecting to Codespaces. Tomorrow I will be at a place with stable and high speed connection and will attach it. If I happen to have the opportunity today, I will do so as well. |
…nd facebook keys)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Issue: #295
🖼️: Front-end
⚙️: Back-end
🏗️: Architecture
We have completed the following:
Process and implementation
- [X] ⚙️ Improve the back-end API schema to send back social media profiles in an array.
- [X] 🖼️ Display icons for known social media platforms.
I have downloaded the FontAwesome library and have implemented it as specified in the official documentation. I felt that it was more practical than downloading svg files one by one, specially since we may be using more social media icons in the future.
Looking forward to your comments.