Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/ahn nath: Add social media icons with links to representative card #361

Merged
merged 8 commits into from
Oct 17, 2022

Conversation

ahn-nath
Copy link
Contributor

Issue: #295

🖼️: Front-end
⚙️: Back-end
🏗️: Architecture

We have completed the following:
Process and implementation

  • [X] ⚙️ Identify social media URLs from the identifiers property.
  • To identify social media URLs from the URLs I used Postman and chose: Instagram, Facebook, Twitter, and Youtube as my targets.
    - [X] ⚙️ Improve the back-end API schema to send back social media profiles in an array.
  • I am using a function that uses the “identifiers” attribute from the representative JSON object as an argument and process the item with a switch statement to get the relevant sites and apply filters as required. I get the social media name, the social media value (username), and set the social media icon to use for it on the front end (example: fa-instagram). Then the funciton returns the array as a new property of the representative JSON that will be sent to the frontend.
    - [X] 🖼️ Display icons for known social media platforms.
    I have downloaded the FontAwesome library and have implemented it as specified in the official documentation. I felt that it was more practical than downloading svg files one by one, specially since we may be using more social media icons in the future.

Looking forward to your comments.

@ahn-nath ahn-nath requested a review from a team as a code owner October 16, 2022 15:13
@ahn-nath ahn-nath self-assigned this Oct 16, 2022
Copy link
Member

@paramsiddharth paramsiddharth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahn-nath Looks good to me, Nath. I appreciate the clean and organized implementation you've done, especially with the separation of concerns and maintaining the code style.

Have you tested it out on some zip codes? If so, could you share some screenshots of what it looks like? It would help ensure the results are consistent with the proposed UI.

@ahn-nath
Copy link
Contributor Author

@paramsiddharth

Hi, Param. Thanks.

Yes, I have tested it several times, normally, with zip codes corresponding to Washington. I cannot upload a screenshot since I have internet connection issues right now, and it prevents me from connecting to Codespaces. Tomorrow I will be at a place with stable and high speed connection and will attach it. If I happen to have the opportunity today, I will do so as well.

@ahn-nath
Copy link
Contributor Author

@paramsiddharth

The screenshots:
Postal code: 98104
image

Postal code: 32118
image

Copy link
Contributor

@manishapriya94 manishapriya94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@manishapriya94 manishapriya94 merged commit 4ab1bdf into main Oct 17, 2022
@manishapriya94 manishapriya94 deleted the dev/ahn-nath branch October 17, 2022 11:42
@joeyouss joeyouss added the week 4 label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants