Skip to content
This repository has been archived by the owner on Apr 10, 2023. It is now read-only.

Create password reset confirmation modal #677

Closed
knjk04 opened this issue Apr 15, 2021 · 6 comments
Closed

Create password reset confirmation modal #677

knjk04 opened this issue Apr 15, 2021 · 6 comments
Assignees
Labels
enhancement New feature or improvement of an existing feature request frontend HTML, CSS or TypeScript related good first issue Good for newcomers react Implementation is in React (JSX with TypeScript)
Milestone

Comments

@knjk04
Copy link
Member

knjk04 commented Apr 15, 2021

Describe the solution you'd like
image

Create the password reset confirmation modal as shown above. This modal should be responsive and use our existing modal component as a starting point.

As with our other modal, this modal should show in the middle of the screen.

Additional context
First, a user should click on the 'Forgot password' link:
image

Then, the user should enter an email address and click on the 'Send me a password reset link' button:
image

Finally, the password reset modal should appear (later on, we'll only show this final modal if we get a successful response from the backend).

Create your feature branch from 0.2.0 and set the destination branch in your pull request to 0.2.0.

@knjk04 knjk04 added enhancement New feature or improvement of an existing feature request good first issue Good for newcomers react Implementation is in React (JSX with TypeScript) frontend HTML, CSS or TypeScript related labels Apr 15, 2021
@RivaD2
Copy link
Collaborator

RivaD2 commented Apr 19, 2021

@knjk04 I would be happy to take this one! Seems like a natural progression since my last contribution :)

@knjk04
Copy link
Member Author

knjk04 commented Apr 20, 2021

@RivaD2 That's great, thank you very much!

@knjk04 knjk04 added this to the 0.2.0 milestone Apr 20, 2021
@RivaD2
Copy link
Collaborator

RivaD2 commented Apr 20, 2021

@knjk04 My approach would be this:
First create the PasswordResetModal Class-based component which makes use of IModalProps. I would import in the base Modal component and make the necessary changes for the text and button.

From there I have a quick question. For right now, since there is no endpoint, am I hooking up the 'Send me a password reset Link' button to just open the new PasswordResetModal that I am creating and also completing some work on the email input ?

Thank you :)

@knjk04
Copy link
Member Author

knjk04 commented Apr 21, 2021

The approach sounds good!

From there I have a quick question. For right now, since there is no endpoint, am I hooking up the 'Send me a password reset Link' button to just open the new PasswordResetModal that I am creating and also completing some work on the email input ?

Yes, that would be great.

Thanks!

@RivaD2
Copy link
Collaborator

RivaD2 commented Apr 21, 2021

@knjk04 I am going to build this out as mentioned above and then possibly refactor as I can tell there will be a lot of redundant code between the forgotPasswordModal and passwordResetModal (Both share the same styles and the only thing that changes are the buttons and text values). I think I can set a variable in state that will control the text etc. and depending on the change, will show the passwordResetModal contents instead.

@knjk04
Copy link
Member Author

knjk04 commented Apr 22, 2021

@RivaD2 That's great, thanks!

@RivaD2 RivaD2 mentioned this issue Apr 25, 2021
8 tasks
@knjk04 knjk04 closed this as completed Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or improvement of an existing feature request frontend HTML, CSS or TypeScript related good first issue Good for newcomers react Implementation is in React (JSX with TypeScript)
Projects
None yet
Development

No branches or pull requests

2 participants