Skip to content
This repository has been archived by the owner on Mar 25, 2023. It is now read-only.

Set up Google Java style guide linter as CI step #157

Open
knjk04 opened this issue Mar 20, 2022 · 1 comment · May be fixed by #162
Open

Set up Google Java style guide linter as CI step #157

knjk04 opened this issue Mar 20, 2022 · 1 comment · May be fixed by #162
Assignees
@knjk04
Labels
dx Developer experience-related enhancement New feature or request

Comments

@knjk04
Copy link
Member

knjk04 commented Mar 20, 2022

Is your feature request related to a problem? If so, please describe.
We currently rely on manually checking style guide violations

Describe the solution you'd like
Add a GitHub action that can check if any style guide recommendations were violated. If so, the step should fail. This should run before the unit tests CI step.

Additional context

  • Be sure to read the contributing guidelines first!
  • Discuss your implementation approach with us before we assign you to it
  • Provide us with an estimate on how long you think it will take you to complete
  • Branch from main and set main as the destination branch in your pull request

If you need help with anything, we'll be happy to help you over a GitHub Q&A discussion or our Slack workspace
@knjk04 knjk04 added enhancement New feature or request dx Developer experience-related labels Mar 20, 2022
@knjk04 knjk04 self-assigned this Mar 20, 2022
ooutofmind pushed a commit to ooutofmind/books-api that referenced this issue Oct 3, 2022
@vlparf
Set up Google Java style guide linter as CI step Project-Books#157
fbd35e5
@ooutofmind ooutofmind linked a pull request Oct 4, 2022 that will close this issue
Open
7 tasks
@ooutofmind
Copy link

@knjk04 could you please review my PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@knjk04 knjk04

Labels
dx Developer experience-related enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set up Google Java style guide linter as CI step ooutofmind/books-api
2 participants
@knjk04 @ooutofmind