-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove required dependency on scikit-image and scipy #232
Comments
Closed
6 tasks
This is also linked to #290 where a related issue is highlighted but with cupy |
This was referenced May 27, 2020
This was referenced Jun 6, 2020
Merged
Merged
Merged
this is mostly done -- scipy removed, scikit-image becomes an optional for the connected component analysis I'm closing this in favour of #554 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
scikit-image
andscipy
are currently required dependencies of MONAI. However, it looks like these are used to implement a small number of features that can be implemented with PyTorch.Limiting the number of required dependencies is good practice and for the particular case at end, replacing these implementations by PyTorch ones may help towards fixing #189
See https://github.com/kornia/kornia/blob/master/kornia/geometry/transform/imgwarp.py#L126 foe examples of replacing
skimage.transform.resize
andscipy.ndimage.zoom
with PyTorch based code based onaffine_grid
andgrid_sample
. There is related discussion in #112The text was updated successfully, but these errors were encountered: