Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional issues with the library (PBP 0.2 BETA) #19

Closed
qiracy opened this issue Jan 14, 2023 · 9 comments
Closed

Functional issues with the library (PBP 0.2 BETA) #19

qiracy opened this issue Jan 14, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@qiracy
Copy link
Contributor

qiracy commented Jan 14, 2023

  1. It seems unable to run exec files that are set to be run as admin only UNLESS you also run the pbp app as admin. I don't know if this is intended or not, but if is it should be clarified somewhere. If it's not, I guess solving it could be done by either requiring pbp to be run as admin or by somehow making it capable of opening those exec files.

  2. When you try to edit a game in your library and click "Done", it automatically closes the app and doesn't even save your edit. Clicking off after editing to avoid the app closing doesn't work either so there's no way to save an edit right now.

@infinity-plus
Copy link
Contributor

Point 1 seems to be pretty clear.
Point 2 we need to test.

Can you tell me what exactly you edited?

@qiracy
Copy link
Contributor Author

qiracy commented Jan 14, 2023

It seems to happen with everything I edit. However, this bug doesn't affect everything. As far as I can tell it's only affecting games with execs that need to be run as admin.

@qiracy qiracy changed the title Functional issues with the library Functional issues with the library (PBP 0.2 BETA) Jan 14, 2023
@Brisolo32 Brisolo32 added the bug Something isn't working label Jan 14, 2023
@zun1uwu
Copy link
Contributor

zun1uwu commented Jan 14, 2023

Please run PBP through cmd.exe or another shell and provide the output after it closes.

@infinity-plus
Copy link
Contributor

it's only affecting games with execs that need to be run as admin.

I cannot reproduce the issue as I do not have any games that require to be run as admin. We could add an option to run as admin if we figure out the way to know which games have these requirements.

@Brisolo32
Copy link
Contributor

It's been some time since the last comment on this issue. Is it still present @Q99kek?

@qiracy
Copy link
Contributor Author

qiracy commented Apr 8, 2023

Yeah. Editing games with execs that need to be run as admin doesn't work at all and the app just closes whenever I try, regardless if I run PBP itself as admin or not. Running games with admin execs only works if I also run PBP as admin. Unsure of what's causing it to not work, tried running it through cmd but it gives no output after it closes

@Brisolo32
Copy link
Contributor

Brisolo32 commented Apr 17, 2023

Running games with admin needs PBP to run as admin, since, well you need admin to run apps/games as admin.
Editing games will be left to the devs who use Windows, since on Linux I don't have this issue

Edit: Closed by mistake. Sorry

@Brisolo32 Brisolo32 reopened this Apr 17, 2023
@MargaritaBarker
Copy link
Contributor

MargaritaBarker commented Apr 20, 2023

  1. When you try to edit a game in your library and click "Done", it automatically closes the app and doesn't even save your edit. Clicking off after editing to avoid the app closing doesn't work either so there's no way to save an edit right now.

Fixed.

@infinity-plus
Copy link
Contributor

Since the issue is partially fixed, closing this in favour of specific issue #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants