Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to continue rebase on conflict #53

Open
sZXZ opened this issue Aug 2, 2022 · 5 comments
Open

No way to continue rebase on conflict #53

sZXZ opened this issue Aug 2, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@sZXZ
Copy link

sZXZ commented Aug 2, 2022

You ca create conflict by naming assets in a same way
In this case user can remove their conflicting files with reset and only button missing is "continue rebase"

@mastercoms
Copy link
Member

How about locking new assets?

@sZXZ
Copy link
Author

sZXZ commented Aug 4, 2022

Yeah locking helps. But if two users commit new file with a same name in the same time there is a conflict. I understand that this probably rare thing to have. But solution looks quite simple. Just to have a button for "continue rebase" if you want to discard your changes. If you want to keep them it's harder.

@mastercoms
Copy link
Member

But if there is a lock before the new file is pushed, another user will not be able to make their own. I am just trying to avoid conflict states as much as possible. I do think in general the pull in editor is designed to overwrite local changes with server ones, but yes it would be good to handle the full process of resolution once it's done. So seems like there's 2 tasks here, is what I'm saying.

@sZXZ
Copy link
Author

sZXZ commented Aug 4, 2022

You can lock file that doesn't exist on a server? I wasn't aware that this is possible

@mastercoms
Copy link
Member

mastercoms commented Aug 4, 2022

Yes, it's allowed by GitHub at least. I'm not sure if it's part of the standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants