Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recreates PR#87: Scaling Schemes #183

Merged
merged 3 commits into from May 25, 2019
Merged

Recreates PR#87: Scaling Schemes #183

merged 3 commits into from May 25, 2019

Conversation

intere
Copy link
Collaborator

@intere intere commented May 17, 2019 •
edited

Background

Breaking Changes

There should be no breaking changes

Meta

  • Tied to Version Release(s): next (post 1.1.0)

Checklist

  • Appropriate label has been added to this PR (i.e., Bug, Enhancement, etc.).
  • Documentation has been added to all open, and public scoped methods and properties.
  • Changelog has been updated
  • Tests have have been added to all new features. (not a requirement, but helpful)
  • Image/GIFs have been added for all UI related changed.

Screenshots

@intere intere self-assigned this May 17, 2019
@intere intere changed the base branch from master to develop May 17, 2019 22:08
@intere intere mentioned this pull request May 17, 2019
Closed
@intere intere changed the title Scaling Schemes Recreates PR#87 Scaling Schemes May 17, 2019
@intere intere changed the title Recreates PR#87 Scaling Schemes Recreates PR#87: Scaling Schemes May 17, 2019
@Thomasp1
Copy link

I've tested it and seems to work fine

@aaronbrethorst aaronbrethorst self-assigned this May 20, 2019
@intere intere marked this pull request as ready for review May 25, 2019 20:36
aaronbrethorst
aaronbrethorst approved these changes May 25, 2019
View reviewed changes
Copy link
Collaborator

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aaronbrethorst aaronbrethorst merged commit bca0fc3 into AndrewHartAR:develop May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbrethorst aaronbrethorst aaronbrethorst approved these changes

Assignees

@aaronbrethorst aaronbrethorst

@intere intere

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@intere @Thomasp1 @aaronbrethorst