Fix #7: Generate manifest.json in output root #20
Conversation
There was a problem hiding this comment.
So one thing about this is that without the service worker, this probably wouldn't be "true" PWA, right? Just curious if you would consider this one step in implementing a PWA? Should define more incremental steps in the ticket to track as a master list of features to add?
For instance, if a service worker is added, it would require the site has to run over HTTPS. Is that something we would want to make default in this app? Or just provide instructions for how to add? Also, managing the cache of service works can be tricky, so that seems to make more of a case to account for documentation / contingencies / opt-in ability.
Thoughts?
|
You're right that a SW is required for the 💯 in Lighthouse, but As far as whether it should be included in CEA, maybe a CLI flag? Could put the pieces in place for something basic, with a set of dedicated instructions on how and where to make changes? |
There was a problem hiding this comment.
Cool, so sounds like we would technically want to keep #8 open and add these takeaways / additional actions items and keep it open after merging this. I'll make the updates in the issue.
but it seems the site defaults to that already, no?
not sure what you mean here?
|
@DevLab2425
hah, yes, I knew you mean HTTPS, I was more inquiring about your assumption of default behavior. To my knowledge, this project doesn't yet make any assumptions about that, but by enabling a SW by default, it would. |
Related Issue
Resolves #7
Summary of Changes
I noticed the Webpack Favicon plugin was generating a
manifest.json, but in a subfolder (/icons). By modifying where the icons are generated, themanifest.jsonis generated in the root of the output folder, which is typically a best practice when including a manifest.With that, a hardcoded
<link />was added to the HTML to include themanifest.jsonfile.This PR may not complete the PWA task since it does not include a service worker, however, it's a step in the PWA direction.