Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<script> tags using optimization attributes have a space before the closing bracket of the opening tag #1052

Open
thescientist13 opened this issue Feb 5, 2023 · 0 comments
Labels
CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) good first issue Good for newcomers
Milestone

Comments

@thescientist13
Copy link
Member

Type of Change

Enhancement / Bug / Other

Summary

If you notice in the source of the Greenwood website, the Apollo data and the webcomponents loader have a space before the closing bracket ( >) of the opening tag.

<script data-state="apollo" >
  window.__APOLLO_STATE__ = true;
</script>

  <!-- ... -->

  <script >
    /* ... */
  </script>

Details

It seems related to how these optimization attributes are being removed from the HTML during the optimization step as both of these leverage those custom attributes.

Probably good to make sure this isn't happening for <link> tags too.


Not a big deal but something worth looking into.

@thescientist13 thescientist13 added good first issue Good for newcomers CLI labels Feb 5, 2023
@thescientist13 thescientist13 changed the title <script> tags using optimization attributes have a space before the closing bracket in the opening tag <script> tags using optimization attributes have a space before the closing bracket of the opening tag Feb 5, 2023
@thescientist13 thescientist13 added the enhancement Improve something existing (e.g. no docs, new APIs, etc) label Nov 4, 2023
@thescientist13 thescientist13 added this to the 1.0 milestone Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) good first issue Good for newcomers
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant