Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore support for CSS bundling (w/Rollup) #427

Closed
2 of 10 tasks
thescientist13 opened this issue Nov 7, 2020 · 0 comments
Closed
2 of 10 tasks

restore support for CSS bundling (w/Rollup) #427

thescientist13 opened this issue Nov 7, 2020 · 0 comments
Assignees
@thescientist13
Labels
alpha.0 CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) P0 Critical issue that should get addressed ASAP v0.10.0
Projects
5 - Architectural Digest
Milestone
No Bundle Feature...

Comments

@thescientist13
Copy link
Member

thescientist13 commented Nov 7, 2020 •
edited
Loading

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

As part of #355 and #418 , add support for CSS bundling with Rollup.

Details

Right now all the CSS is just being copied over as part of copy s lifecycle. It should be bundled just like JavaScript is. This includes:

  1. pull files in from index.html, not the copy lifecycle
  2. support node_modules, which should fix missing prism.css
  3. minification
  4. filename hashing
  5. other?
@thescientist13 thescientist13 added the enhancement Improve something existing (e.g. no docs, new APIs, etc) label Nov 7, 2020
@thescientist13 thescientist13 mentioned this issue Nov 7, 2020
Closed
53 tasks
@thescientist13 thescientist13 added the P0 Critical issue that should get addressed ASAP label Nov 8, 2020
@thescientist13 thescientist13 self-assigned this Nov 8, 2020
@thescientist13 thescientist13 mentioned this issue Nov 12, 2020
Merged
12 tasks
@thescientist13 thescientist13 moved this from TODO to IN PROGRESS in 5 - Architectural Digest Nov 14, 2020
@thescientist13 thescientist13 mentioned this issue Nov 16, 2020
Merged
20 tasks
@thescientist13 thescientist13 mentioned this issue Dec 1, 2020
Merged
2 tasks
@thescientist13 thescientist13 moved this from IN PROGRESS to IN REVIEW in 5 - Architectural Digest Dec 1, 2020
@thescientist13 thescientist13 moved this from IN REVIEW to DONE in 5 - Architectural Digest Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
alpha.0 CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) P0 Critical issue that should get addressed ASAP v0.10.0
Projects
No open projects
5 - Architectural Digest
DONE
Milestone
No Bundle Feature Parity
Development

No branches or pull requests
1 participant
@thescientist13