Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<link> tags that reference remote URLs break the build (v0.10.0 alpha) #491

Closed
1 of 5 tasks
thescientist13 opened this issue Mar 20, 2021 · 0 comments · Fixed by #494
Closed
1 of 5 tasks

<link> tags that reference remote URLs break the build (v0.10.0 alpha) #491

thescientist13 opened this issue Mar 20, 2021 · 0 comments · Fixed by #494
Assignees
@thescientist13
Labels
alpha.9 bug Something isn't working CLI P0 Critical issue that should get addressed ASAP v0.10.0
Projects
5 - Architectural Digest
Milestone
No Bundle Feature...

Comments

@thescientist13
Copy link
Member

thescientist13 commented Mar 20, 2021 •
edited
Loading

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

If you try and so something like this in your template

<head>
  <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Avenir+Next&display=swap">

Thanks go bonkos, and in fact, we also have an unhandled Promise rejection error.
Screen Shot 2021-03-20 at 1 27 25 PM

1:24:08 PM: (node:1423) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, open '/opt/build/repo/src/fonts.googleapis.com/css?family'
1:24:08 PM:     at Object.openSync (fs.js:476:3)
1:24:08 PM:     at Object.readFileSync (fs.js:377:35)
1:24:08 PM:     at /opt/build/repo/node_modules/@greenwood/cli/src/config/rollup.config.js:226:31
1:24:08 PM:     at Array.forEach (<anonymous>)
1:24:08 PM:     at Object.buildStart (/opt/build/repo/node_modules/@greenwood/cli/src/config/rollup.config.js:210:19)
1:24:08 PM:     at /opt/build/repo/node_modules/rollup/dist/shared/rollup.js:18765:25
1:24:08 PM:     at async Promise.all (index 1)
1:24:08 PM:     at async rollupInternal (/opt/build/repo/node_modules/rollup/dist/shared/rollup.js:19946:9)
1:24:08 PM:     at async /opt/build/repo/node_modules/@greenwood/cli/src/lifecycles/bundle.js:12:24
1:24:08 PM: (Use `node --trace-warnings ...` to show where the warning was created)
1:24:08 PM: (node:1423) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
1:24:08 PM: (node:1423) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
1:49:36 PM: Canceling deploy

Details

Fix it.

(should definitely make sure to write tests for <link> and <script>`)
@thescientist13 thescientist13 added bug Something isn't working P0 Critical issue that should get addressed ASAP CLI labels Mar 20, 2021
@thescientist13 thescientist13 self-assigned this Mar 20, 2021
This was referenced Mar 20, 2021
Closed
Merged
@thescientist13 thescientist13 moved this from TODO to IN PROGRESS in 5 - Architectural Digest Mar 21, 2021
@thescientist13 thescientist13 mentioned this issue Mar 21, 2021
Merged
@thescientist13 thescientist13 moved this from IN PROGRESS to IN REVIEW in 5 - Architectural Digest Mar 21, 2021
@thescientist13 thescientist13 linked a pull request Mar 21, 2021 that will close this issue
handle no bundling of remote URLs and add error handling for sync rollup hooks #494
Merged
@thescientist13 thescientist13 mentioned this issue Mar 26, 2021
Merged
12 tasks
@thescientist13 thescientist13 moved this from IN REVIEW to DONE in 5 - Architectural Digest Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
alpha.9 bug Something isn't working CLI P0 Critical issue that should get addressed ASAP v0.10.0
Projects
No open projects
5 - Architectural Digest
DONE
Milestone
No Bundle Feature Parity
1 participant
@thescientist13