Chore/issue 428 refactor smoke test and cases #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
force-pushed
the
chore/issue-428-refactor-smoke-test-and-cases
branch
from
3ac1de2
to
b322ac0
Compare
thescientist13
added a commit
that referenced
this pull request
Apr 3, 2021
* refactor smoke test and re-enable * cleanup dupe testing * refactor beforeEach to before * turn coverage checks back on * delete invalid test cases * xdescribe and xit * fix smoke test tag matching and add smoke tests to ggraphql * add more smoke testing * add missing plugin-graphql ChildrenQuery spec * cleanup TODOs for path references normalization * remove TODOs that will be tracked via github * clean up rollup todos * restore local request blocking to puppeteer * remove commented code from config * final thresholds for now * clean up missed TODOs and console logs
thescientist13
added a commit
that referenced
this pull request
Apr 3, 2021
* refactor smoke test and re-enable * cleanup dupe testing * refactor beforeEach to before * turn coverage checks back on * delete invalid test cases * xdescribe and xit * fix smoke test tag matching and add smoke tests to ggraphql * add more smoke testing * add missing plugin-graphql ChildrenQuery spec * cleanup TODOs for path references normalization * remove TODOs that will be tracked via github * clean up rollup todos * restore local request blocking to puppeteer * remove commented code from config * final thresholds for now * clean up missed TODOs and console logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves test / TODOs for #428
Summary of Changes
beforeEach->before<head></head>tag matchingChildrenQuery<title>tags (bug)build? (for npx)<img>tag in header and banner component