Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add code coverage reporting and set thresholds #50

Closed
1 of 5 tasks
thescientist13 opened this issue Apr 18, 2019 · 1 comment
Closed
1 of 5 tasks

add code coverage reporting and set thresholds #50

thescientist13 opened this issue Apr 18, 2019 · 1 comment
Assignees
@thescientist13
Labels
chore unit testing, maintenance, etc v0.2.0
Projects
1

Comments

@thescientist13
Copy link
Member

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

While we do have unit testing for this project, adding a coverage reporter would be a good way to ensure that we are covering (as much as possible) the critical code paths of the build.

Details

Could use something like nyc
https://stackoverflow.com/questions/16633246/code-coverage-with-mocha
@thescientist13 thescientist13 added the chore unit testing, maintenance, etc label Apr 18, 2019
@hutchgrant
Copy link
Member

hutchgrant commented Apr 19, 2019 •
edited

Another popular solution is codecov

All code coverage reports are integrated in github and uploaded to codecov.io

@thescientist13 thescientist13 mentioned this issue Apr 28, 2019
Closed
5 tasks
@thescientist13 thescientist13 self-assigned this May 5, 2019
@thescientist13 thescientist13 added this to IN REVIEW in 1 May 5, 2019
@thescientist13 thescientist13 mentioned this issue May 5, 2019
Merged
9 tasks
@thescientist13 thescientist13 moved this from IN REVIEW to DONE in 1 May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
chore unit testing, maintenance, etc v0.2.0
Projects
No open projects
1
DONE
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thescientist13 @hutchgrant