Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

an empty greenwood.config.js breaks the build (due to devServer?) #66

Closed
1 of 5 tasks
thescientist13 opened this issue Apr 30, 2019 · 0 comments · Fixed by #68
Closed
1 of 5 tasks

an empty greenwood.config.js breaks the build (due to devServer?) #66

thescientist13 opened this issue Apr 30, 2019 · 0 comments · Fixed by #68
Assignees
Labels
bug Something isn't working P0 Critical issue that should get addressed ASAP v0.2.0
Projects
Milestone

Comments

@thescientist13
Copy link
Member

thescientist13 commented Apr 30, 2019

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Having an empty greenwood.config.js results in a build error

module.exports = {};
$ yarn build
yarn run v1.12.3
$ node ./packages/cli/index.js build
-------------------------------------------------------
Welcome to Greenwood ♻️
-------------------------------------------------------
Reading project config
undefined
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Details

Seems to be related to how devServer is being error checked perhaps (as part of #22 ), with no fallback handling?
https://github.com/ProjectEvergreen/greenwood/blob/master/packages/cli/lib/config.js#L29

@thescientist13 thescientist13 added the bug Something isn't working label Apr 30, 2019
@thescientist13 thescientist13 self-assigned this Apr 30, 2019
@thescientist13 thescientist13 added this to IN PROGRESS in 1 Apr 30, 2019
@thescientist13 thescientist13 moved this from IN PROGRESS to IN REVIEW in 1 May 1, 2019
@thescientist13 thescientist13 added P0 Critical issue that should get addressed ASAP v0.2.0 labels May 1, 2019
@thescientist13 thescientist13 moved this from IN REVIEW to DONE in 1 May 2, 2019
@thescientist13 thescientist13 added this to the MVP milestone Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P0 Critical issue that should get addressed ASAP v0.2.0
Projects
No open projects
1
DONE
Development

Successfully merging a pull request may close this issue.

1 participant