Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a user I should be able to use a global CSS file #7

Closed
1 of 5 tasks
thescientist13 opened this issue Mar 26, 2019 · 1 comment
Closed
1 of 5 tasks

As a user I should be able to use a global CSS file #7

thescientist13 opened this issue Mar 26, 2019 · 1 comment
Assignees
@hutchgrant
Labels
enhancement Improve something existing (e.g. no docs, new APIs, etc) P0 Critical issue that should get addressed ASAP question Further information is requested v0.2.0
Projects
1
Milestone
POC

Comments

@thescientist13
Copy link
Member

thescientist13 commented Mar 26, 2019 •
edited

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

All projects will inevitably require some CSS. At minimum, a file for a basic global CSS file should be supported.

Details

  1. A default CSS file should be created in templates/ that should be built and imported into the final output
  2. A user provided file in src/styles.css should be supported and bundled instead, if auto detected
  3. Unit tests should be written for both cases above
  4. Update README documentation to demonstrate the capabilities

Questions

  1. Should this be supported in templates instead? Should we support both options?
@thescientist13 thescientist13 added the enhancement Improve something existing (e.g. no docs, new APIs, etc) label Mar 26, 2019
@thescientist13 thescientist13 added this to the MVP milestone Mar 26, 2019
@thescientist13 thescientist13 mentioned this issue Mar 26, 2019
Closed
5 tasks
@thescientist13 thescientist13 added this to TODO in 1 Mar 27, 2019
@thescientist13 thescientist13 mentioned this issue Apr 3, 2019
Closed
5 tasks
@hutchgrant
Copy link
Member

hutchgrant commented Apr 13, 2019 •
edited

This will require changes as per #11 to config/compilation.

This will have limitations because of shadow dom. Most style changes will have to happen on an an individual page-template anyway.

@thescientist13 thescientist13 added the question Further information is requested label Apr 14, 2019
@thescientist13 thescientist13 added the P0 Critical issue that should get addressed ASAP label May 5, 2019
@hutchgrant hutchgrant mentioned this issue May 10, 2019
Merged
@hutchgrant hutchgrant moved this from TODO to IN REVIEW in 1 May 10, 2019
@thescientist13 thescientist13 moved this from IN REVIEW to DONE in 1 May 15, 2019
This was referenced Aug 2, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hutchgrant hutchgrant

Labels
enhancement Improve something existing (e.g. no docs, new APIs, etc) P0 Critical issue that should get addressed ASAP question Further information is requested v0.2.0
Projects
No open projects
1
DONE
Milestone
POC
Development

No branches or pull requests
2 participants
@thescientist13 @hutchgrant