Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create Lit specific polyfill plugin #728

Open
1 of 5 tasks
thescientist13 opened this issue Sep 14, 2021 · 1 comment
Open
1 of 5 tasks

create Lit specific polyfill plugin #728

thescientist13 opened this issue Sep 14, 2021 · 1 comment
Assignees
Labels
documentation Greenwood specific docs feature New feature or request good first issue Good for newcomers Plugins Greenwood Plugins SSR
Milestone

Comments

@thescientist13
Copy link
Member

thescientist13 commented Sep 14, 2021

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

As part of the Lit@2 upgrade, one of the things we needed to add was support for Lit specific polyfills, as seen in #719 . As we shouldn't have anything library specific in the core CLI and so should move this logic out into a plugin for those who want to use Lit + Puppeteer.

Details

So effectively we just need to make a new (resource) plugin to isolate the Lit specific checks and polyfill add / cleanup from plugin-standard-html. We should also make sure to add some tests here as well.

We should also make sure to document in its README the relationship to Lit / SSR as well as our standard plugin-polyfill.

We should also clean up TODOs from #974 related to Lit Polyfill popping up and is hardcoded into the Node Modulesresource plugin.

This could almost be considered a breaking change, so best to do it pre 1.0.0


This is actually part of the polyfills plugin, so not sure if that's OK for now? 🤔

In either #955 and #1197 it will get moved out of the CLI at least.

@thescientist13
Copy link
Member Author

I wonder if this should just get bundled with the (eventual) renderer work in #710 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Greenwood specific docs feature New feature or request good first issue Good for newcomers Plugins Greenwood Plugins SSR
Projects
Status: 🔖 Ready
Development

No branches or pull requests

1 participant