Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect <head> tag assembly for app and page templates when page content also includes head "like" tags #782

Closed
1 of 5 tasks
thescientist13 opened this issue Oct 31, 2021 · 0 comments · Fixed by #783
Closed
1 of 5 tasks

incorrect <head> tag assembly for app and page templates when page content also includes head "like" tags #782

thescientist13 opened this issue Oct 31, 2021 · 0 comments · Fixed by #783
Assignees
@thescientist13
Labels
alpha.3 bug Something isn't working CLI v0.19.0
Projects
7 - SSR and External Data Sources
Milestone
1.0

Comments

@thescientist13
Copy link
Member

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Contents of a page's templates <head> like <script> and <style> are incorrectly getting templated together in the wrong place if there happens to be one of these in the <body> tag of the app template, and so those tags will appended there, instead of in the <head>.

Noticed as part of working on #712 (comment)

Details

For example. given this app and page template

<!-- app.html -->
<html>
  <body>
   <link rel="xxx" ....></link>
  </body>
</html>
<!-- page.html -->
<html>
  <head>
   <link rel="stylesheet" ....></link>
  </head>
</html>

Expected

One in the <head> (page) and one in the <body> (app)

<html>
  <head>
   <link rel="stylesheet" ....></link>
  </head>
  <body>
   <link rel="xxx" ....></link>
  </body>
</html>

Actual

Two in the <body> (app and page)

<!-- page.html -->
<html>
  <body>
   <link rel="xxx" ....></link>
   <link rel="stylesheet" ....></link>
  </body>
</html>
@thescientist13 thescientist13 added bug Something isn't working CLI labels Oct 31, 2021
@thescientist13 thescientist13 added this to the 1.0 milestone Oct 31, 2021
@thescientist13 thescientist13 self-assigned this Oct 31, 2021
@thescientist13 thescientist13 changed the title incorrect <head> tag assembly for app and page templates incorrect <head> tag assembly for app and page templates when page content also includes head "like" tags Oct 31, 2021
@thescientist13 thescientist13 mentioned this issue Oct 31, 2021
Merged
@thescientist13 thescientist13 mentioned this issue Nov 4, 2021
Merged
@thescientist13 thescientist13 moved this from IN REVIEW to DONE in 7 - SSR and External Data Sources Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
alpha.3 bug Something isn't working CLI v0.19.0
Projects
No open projects
7 - SSR and External Data Sources
DONE
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

correctly merge page template <head> tags with app template <head> tags ProjectEvergreen/greenwood
1 participant
@thescientist13