Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible naming collisions #22

Open
rpruim opened this issue Jun 27, 2018 · 0 comments
Open

possible naming collisions #22

rpruim opened this issue Jun 27, 2018 · 0 comments

Comments

@rpruim
Copy link
Contributor

rpruim commented Jun 27, 2018

Currently, size and alpha (and a few other things) are arguments for mod_plot(). This means that using those as variable names in the model will preclude using ... to set their values.

Going forward, if we want to allow things like size = ~var1 (to map size to var1) but also possibly size = 7 (to set the value of a variable in the model), then we have an ambiguity. A similar things happens in gf_dist(), see ProjectMOSAIC/ggformula#74 for one possible solution. That solution would be to use plot_size for the plot property when size is a variable in the model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant