Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opensea-js v7 planning #1056

Closed
10 of 17 tasks
ryanio opened this issue Jun 29, 2023 · 9 comments · Fixed by #1310
Closed
10 of 17 tasks

opensea-js v7 planning #1056

ryanio opened this issue Jun 29, 2023 · 9 comments · Fixed by #1310

Comments

@ryanio
Copy link
Collaborator

ryanio commented Jun 29, 2023

Breaking changes

  • Upgrade to ethers v6 (related issue: ethers v6 #1042)
    • Upgrade JS target version to use native BigInt
    • update: in progress, upgrading seaport-js dependency to ethers v6 first
  • Remove wallet constructor param and just use provider, can be renamed to signerOrProvider (wallet is a subclass of provider)
  • Remove V1 getAsset and getAssets api calls (and associated types)
  • Put chain param from getNFTsByContract/getNFT/refreshNFTMetadata at the end / last parameter as optional and default to sdk.chain
  • Remove legacy SDK export OpenSeaPort

Non-breaking changes (applicable for inclusion in patch or minor releases)

@kr1p70n1c
Copy link

kr1p70n1c commented Jul 7, 2023

@ryanio I assume the item Bulk using [TransferHelper] means to add a SDK function for bulkTransfer ?

@kieutuan218
Copy link

@ryanio How about API "Retrieve NFTs by Wallet Address" ?
Is there currently a way for me to obtain a list of NFTs based on wallet address and collection address?

@ryanio
Copy link
Collaborator Author

ryanio commented Jul 10, 2023

@kieutuan218 yes there is getNFTsByCollection() available in the sdk.

for NFTs by user there is a generic get() fn that can be used with https://docs.opensea.io/v1.0/reference/getting-assets, i'll add it to the non breaking list for a nice-to-have

@kieutuan218
Copy link

@ryanio https://docs.opensea.io/v1.0/reference/getting-assets This API seems to only work with the Ethereum network. I tried querying a collection on the Polygon network, but the API returned an empty result.
Ex: https://opensea.io/collection/dahood-punks

@ryanio
Copy link
Collaborator Author

ryanio commented Jul 10, 2023

@kieutuan218 ah right, we'll need to add that in a v2 upgrade to the endpoint at some point. thanks for pointing out.

@pixelpawnshop
Copy link

GMGM. Was texting with thenerdassassin about adding priority fee, max gas and gaslimit as a option to add in the sdk. Would be a great feature to have.

@thenerdassassin thenerdassassin pinned this issue Aug 22, 2023
@Com1ngS00n
Copy link

Hello Nerdassassin, I've been following this and am currently waiting for a gas limit option as well. Only then can I continue with my project unfortunately.. will this be added soon or will it take a while? Thanks for your support! Greetings ComingSoon

@Slers
Copy link

Slers commented Sep 5, 2023

Do we have an ETA for v7? The fact that ethers-js v6 is not yet supported is quite cumbersome.

@ryanio ryanio changed the title opensea-js v7 planning opensea-js v8 planning Dec 5, 2023
@ryanio ryanio changed the title opensea-js v8 planning opensea-js v7 planning Dec 6, 2023
@ryanio
Copy link
Collaborator Author

ryanio commented Dec 6, 2023

@Slers I'm working on upgrading to ethers v6 now, starting with seaport-js, hoping to release it in opensea-js in the next couple days!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants