Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #217 - guidance on running cookbooks #28

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Fixed #217 - guidance on running cookbooks #28

merged 1 commit into from
Jun 29, 2022

Conversation

clyne
Copy link
Contributor

@clyne clyne commented Jun 29, 2022

No description provided.

@clyne clyne requested a review from a team as a code owner June 29, 2022 16:36
@netlify
Copy link

netlify bot commented Jun 29, 2022

Deploy Preview for voluble-peony-e23e5f ready!

Name Link
🔨 Latest commit af2f14c
🔍 Latest deploy log https://app.netlify.com/sites/voluble-peony-e23e5f/deploys/62bc7f8faf38660009e75fa5
😎 Deploy Preview https://deploy-preview-28--voluble-peony-e23e5f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@clyne clyne requested review from brian-rose and mgrover1 and removed request for a team June 29, 2022 16:40
Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clyne your text looks good to me! The previews aren't working for this repo right now but I don't think we need to wait for that to merge this PR.

@clyne
Copy link
Contributor Author

clyne commented Jun 29, 2022

Good deal. I guess the question for you and @mgrover1 is should we remove or alter the instructions in the cookbook template, or leave as is?

@mgrover1
Copy link
Contributor

@clyne I would suggest leaving it in there - there may be cookbook-specific instructions, and it simplifies pointing someone directly to a cookbook with the overview and installation instructions in one spot

Copy link
Contributor

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great summary of how to run the notebooks - I think this is a good spot for it.

@clyne
Copy link
Contributor Author

clyne commented Jun 29, 2022

@clyne I would suggest leaving it in there - there may be cookbook-specific instructions, and it simplifies pointing someone directly to a cookbook with the overview and installation instructions in one spot

That is the easy thing to do :-). Works for me.

@clyne clyne merged commit 698bfca into main Jun 29, 2022
@clyne
Copy link
Contributor Author

clyne commented Jun 29, 2022

Fixed #17 (not 217)

@erogluorhan erogluorhan deleted the issue_17 branch March 29, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants