Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components #1

Merged
merged 15 commits into from Sep 16, 2022
Merged

Components #1

merged 15 commits into from Sep 16, 2022

Conversation

PromzzyKoncepts
Copy link
Owner

@PromzzyKoncepts PromzzyKoncepts commented Sep 16, 2022

Hey There 👋🏻

In this PR, you will find that I:

  • Initialised React app.
  • Created a directory for your components.
  • Added React Router and set two <Route>s and <Link>s for the app's navigation
  • Created a component called Book for displaying a single book (receive a title and an author as prop) and reused it in a component that displays a list of books.
  • Created a separate component for this form (with inputs for a title and an author
  • Styled the project
  • Checked for linters
  • Committed and pushed changes

Happy Reviewing...

Copy link

@elisha2kyakpo1 elisha2kyakpo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋 @PromzzyKoncepts,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • The PR title and description looks professional ✔️
  • No linter errors👍
  • You have a descriptive and professional readme file 👍

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@netlify
Copy link

netlify bot commented Sep 16, 2022

Deploy Preview for bookstore-redux ready!

Name Link
🔨 Latest commit f5a06c9
🔍 Latest deploy log https://app.netlify.com/sites/bookstore-redux/deploys/6324c48d4282cf0008a7f9d7
😎 Deploy Preview https://deploy-preview-1--bookstore-redux.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@PromzzyKoncepts PromzzyKoncepts merged commit a499c46 into dev Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants