Leaderboard hit api #2
Conversation
There was a problem hiding this comment.
Hi @PromzzyKoncepts,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 馃帀
Highlights
- No linters errors 鉁旓笍
- Descriptive Pull Request 鉁旓笍
- Good commit messages 鉁旓笍
- Nice design 馃憤
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!馃憦馃憦馃憦
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| // const dispMessage = () => { | ||
| // messageElt.innerText = 'Score added successfully, click "refresh" to display'; | ||
| // messageElt.className = 'small' |
There was a problem hiding this comment.
- [OPTIONAL] Please kindly delete the comment lines of code to have a clean codebase 馃檭 馃檭
| // const name = document.getElementById('name'); | ||
| // const score = document.getElementById('score'); |
There was a problem hiding this comment.
- [OPTIONAL] Please kindly delete the comment lines of code to have a clean codebase 馃檭 馃檭
| // event handlers for the refresh button | ||
| const refreshBtn = document.getElementById('refresh'); | ||
| refreshBtn.addEventListener('click', () => { | ||
| // getAllScores(); |
There was a problem hiding this comment.
- [OPTIONAL] Please kindly delete the comment lines of code to have a clean codebase 馃檭 馃檭
Hello There 馃槃
Created a new game with a name by using the
API.Made sure that you saved the
IDof my game that will be returned byAPI.Implemented the
Refreshbutton that will get all scores for a game created by a user from theAPI( by receiving data from theAPIand parsing theJSON).Implemented the form
Submitbutton that will save ascorefor a game created by you (sendingdatato theAPI).Used
arrow functionsinstead of thefunctionkeyword.Used
asyncandawaitJavaScript features toconsumethe API.Checked for linter errors
Added, committed and pushed Changes
Happy Reviewing 馃憤馃徎
PLEASE NOTE 馃洃 : You can observe that i went ahead and and finished both activity of today and tomorrow which includes the final stylings and touches, please ignore that and review based on the Project requirements
Thank you 馃