Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final touch #3

Merged
merged 6 commits into from Aug 25, 2022
Merged

Final touch #3

merged 6 commits into from Aug 25, 2022

Conversation

PromzzyKoncepts
Copy link
Owner

Hello There 😄

In this PR, I did the following:

  • Implemented a function that displays an error message when the input is empty

  • Implemented a function that displays a success message when the input is correctly submitted

  • Implemented a function that tells the user how many users and scores have been successfully added

  • Added styles, transitions, and animations to make the UI colorful and accessible and also the UX fun and engaging

  • Used arrow functions instead of the function keyword.

  • Checked for linter errors

  • Added, committed, and pushed Changes

Happy Reviewing 👍🏻

Thank you 🤝

Copy link

@Reem-lab Reem-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PromzzyKoncepts,👋🏻👋🏻

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉🔥🔥💯💯

Highlights ✨✨

📌 No Linters error ✅
📌 Descriptive pull request✅
📌 Great working on the functionality ✅
📌 Good commit messages ✅
📌Professional README file. ✅
📌 Wonderful design ✅💯🔥🔥

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@PromzzyKoncepts PromzzyKoncepts merged commit 2aff5fc into dev Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants