Create functions based on project requirements #2
Conversation
There was a problem hiding this comment.
Hi @PromzzyKoncepts,
Great job !!!
To Highlight! 馃憦 馃煝
鉁旓笍 Good commit messages
鉁旓笍 Descriptive Readme file
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 馃帀
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
N/A
Cheers and Happy coding!馃憦馃憦馃憦
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| localStorage.setItem('tasks: ', JSON.stringify(toDoList)); | ||
| }; | ||
|
|
||
| // const inputVal = document.getElementById('add'); |
There was a problem hiding this comment.
- [OPTIONAL] Please kindly remove
commented codefrom yourcode base, as it makes yourcode basedirty and less readable. To make sure that your codebase is always clean, always remember to remove commented-codes.
| @@ -0,0 +1,112 @@ | |||
| /* eslint-disable max-len */ | |||
There was a problem hiding this comment.
- [OPTIONAL]
Lintersare tools that perform static analysis on software in order to recognize and report adherence/non-adherence to some set of coding best practice.Instead of disablingeslint, it will be nice to fix the issue.
| @@ -1,42 +1,68 @@ | |||
| /* eslint-disable max-len */ | |||
There was a problem hiding this comment.
- [OPTIONAL]
Lintersare tools that perform static analysis on software in order to recognize and report adherence/non-adherence to some set of coding best practice.Instead of disablingeslint, it will be nice to fix the issue.
Hello there 馃
馃挴
Created a new
modulesfolder calledfunctions.jswhere I built all functions for the project 馃挴Created a
functionthat:-
addsa task to the list by pressingenterkey-
setseach task to thelocal storage- deletes a task from local storage and displays output
-
on loadingwindows, displays all tasks from the local storage- allows a user to
editan already added task and save it tolocal storage.Imported and exported all necessary functions.
checked for linter errors and made corrections
Added, committed and pushed all changes
if any changes are required, pls drop comments below
Happy Reviewing! 馃憤馃徎