Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way inapplicable transform steps are handled #204

Closed
marijnh opened this issue Feb 22, 2016 · 2 comments
Closed

Change the way inapplicable transform steps are handled #204

marijnh opened this issue Feb 22, 2016 · 2 comments

Comments

@marijnh
Copy link
Member

marijnh commented Feb 22, 2016

Right now, they just get ignored entirely. This makes debugging them rather hard.

To the user, things may stay the same (you just don't see anything happen when some code tries to do something that isn't valid), but applying the steps should return something more useful than null, and when applied as part of a Transform, the error message should be stored somewhere for debugging purposes.

@kiejo
Copy link
Contributor

kiejo commented Mar 29, 2016

I think this has been fixed with the new StepResult class that was part of the linear positions rewrite. Not sure if there's more to this issue, but otherwise we could close it.

@marijnh
Copy link
Member Author

marijnh commented Mar 29, 2016

It's improved, but I'm still not very happy with the way Transform objects handle failures. I may end up punting to a simple exception-trowing schema and remove the concept of failed Transforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants