Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate AttributeType protocol in favor of just using the plain Attribute class #14

Closed
Revolucent opened this issue Dec 16, 2015 · 2 comments
Closed

Eliminate AttributeType protocol in favor of just using the plain Attribute class #14

Revolucent opened this issue Dec 16, 2015 · 2 comments
Assignees
@Revolucent
Labels
enhancement
Milestone
v3.0

Comments

@Revolucent
Copy link
Member

My original intention in including AttributeType was a form of future-proofing. But the more I think about it, the more I think it is unnecessary. Eliminating AttributeType will simplify a lot of code and will cause no breaking changes I can think of. The use of AttributeType anywhere other than the internal implementation of CDQI is probably quite rare.

If anyone has any objections, please let me know.
@Revolucent Revolucent self-assigned this Dec 16, 2015
@Revolucent Revolucent modified the milestones: v1.2.4, v2.1 Dec 16, 2015
@Revolucent
Copy link
Member Author

This will also make #13 easier to implement.

@Revolucent
Copy link
Member Author

Closed in 5ed9a8e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Revolucent Revolucent

Labels
enhancement
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
1 participant
@Revolucent