Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include date in generated file comment header, maybe a hash instead? #59

Closed
patgoley opened this issue Jun 13, 2017 · 3 comments
Closed

Comments

@patgoley
Copy link
Contributor

Including the date in the generated files causes unnecessary changes in git when run automatically. I'm not sure that the date of generation is important, really only the model version it was generated from. Perhaps a hash of the model itself would be more appropriate? Sorry, I know this is really picky, but I think CDQI is best used in automation (run script phase or CI), and I keep having to commit or reset model files that have changes only because it's a new day. Happy to implement it myself, just let me know what you think.

@Revolucent
Copy link
Member

Sounds great to me. If you submit a pull request, I will integrate it.

@Revolucent
Copy link
Member

Maybe we don't even need the hash.

@patgoley
Copy link
Contributor Author

On second thought, you're right. The changes to the model class itself are enough to know that it's changed. No need for a secondary indicator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants