Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make easy to access table with all public benchmark runs #197

Open
mlocardpaulet opened this issue Jan 7, 2024 · 7 comments
Open

make easy to access table with all public benchmark runs #197

mlocardpaulet opened this issue Jan 7, 2024 · 7 comments
Assignees
Labels

Comments

@mlocardpaulet
Copy link
Contributor

It should be possible to find a table containing the information in the json of the public benchmark runs. Ideally, it would also contain the free text comment that can be added when submitting. This way, if some parameters are not automatically parsed by ProteoBench but is important (at least in the opinion of the person submitting it), it is still possible to access it.

@julianu
Copy link
Contributor

julianu commented Jan 26, 2024

I am working on this for a single module.
Right now, I implement a table below the charts. In this table probably also any additional information of the run can be shown. If also the hash is added, it would solve the issue #209 . Though there it would be nicer to also add the human readable name of the dataset.

This could be enhanced for all data, will try to keep this in mind for the code.

Probably this way of download would also solve #174

@julianu julianu self-assigned this Jan 26, 2024
@RobbinBouwmeester
Copy link
Contributor

@julianu would it be easier if the folder name is the "id" instead of the hash of the intermediate?

@julianu
Copy link
Contributor

julianu commented Jan 29, 2024

That would not matter much, it's just reading out another field.Let's keep the hash for now.

@mlocardpaulet
Copy link
Contributor Author

That would not matter much, it's just reading out another field.Let's keep the hash for now.

I guess the idea was to have something more human readable, right? I think that for this the id is better than the hash

@RobbinBouwmeester
Copy link
Contributor

Sure, but it is more about the folder names, what we display in the table should definitely be the id and not the hash.

@RobbinBouwmeester
Copy link
Contributor

Seems to be available in #239, @mlocardpaulet does this suffice, at least for now?

@julianu
Copy link
Contributor

julianu commented Feb 11, 2024

Agree, looks good. I would integrate the download of the "raw" uploads into this table as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants