Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling/Enabling Modules Doesn't Register/Unregister Blocks/Items #36

Open
sylv256 opened this issue Oct 7, 2020 · 6 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@sylv256
Copy link
Contributor

sylv256 commented Oct 7, 2020

:concern:
also, mixin to datafixerupper so it doesn't delete blocks/items from disabled modules.

@YTG1234
Copy link
Collaborator

YTG1234 commented Oct 7, 2020

Are you reporting a bug or suggesting a change? The title and comment make it very unclear.

@sylv256
Copy link
Contributor Author

sylv256 commented Oct 7, 2020

Bug

@YTG1234 YTG1234 added the bug Something isn't working label Oct 7, 2020
@YTG1234
Copy link
Collaborator

YTG1234 commented Oct 8, 2020

Disabling/Enabling Modules Doesn't Register/Unregister Blocks/Items

You can't register/unregister thingies after the mod initializes. That's how Minecraft's registry works.

@dzwdz
Copy link
Contributor

dzwdz commented Oct 8, 2020

couldn't we always register the blocks, and just remove their crafting recipes/their itemgroups when they get disabled?

@namebee
Copy link
Contributor

namebee commented Oct 8, 2020

I don't think this would work, And if it does it would be really sketchy to do so.

@dzwdz
Copy link
Contributor

dzwdz commented Oct 8, 2020

so, what if someone with all modules disabled joins a server with all modules enabled? if we don't register the blocks, they won't be able to join
also, it will make enabling/disabling blocks at runtime possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants