Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub links don’t open in the native GitHub iOS app #61

Closed
mcmxcdev opened this issue Dec 3, 2022 · 3 comments
Closed

GitHub links don’t open in the native GitHub iOS app #61

mcmxcdev opened this issue Dec 3, 2022 · 3 comments

Comments

@mcmxcdev
Copy link

mcmxcdev commented Dec 3, 2022

Describe the bug:
GitHub links in emails don’t open in native GitHub iOS app but inside Brave browser (default).

Live App Version:
4.1.1 (7303)

Device + OS version
iPhone with iOS 16.1.1.

Can you reproduce the problem each time?
Yes

Steps to reproduce the behavior:

  1. Receive GitHub notifications in ProtonMail
  2. Click on either "View it on GitHub" or "unsubscribe" link
  3. Expect to open inside native GitHub iOS app
  4. Actually opens the link inside the browser which is set as default

Expected behavior
I would expect ProtonMail to detect that I have the GitHub app installed and open links there, which has a better user experience and responsiveness compared to the mobile web version.

Screenshots(If applicable)

Screenshot from 2022-12-03 13-23-09

@dbanty
Copy link

dbanty commented Jan 25, 2023

As a workaround, I've been pressing and holding on the link to get a preview, then clicking the "open link" button (with a Safari icon on it) which opens it in the native GitHub app.

@mcmxcdev
Copy link
Author

That does indeed work as a workaround, thanks so much!

@mcmxcdev
Copy link
Author

mcmxcdev commented Oct 1, 2023

I have just downloaded the GitHub app again and this issue seems to be resolved now.

@mcmxcdev mcmxcdev closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants