Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security issue: SMIME signature verification is still broken #216

Open
tk-innoq opened this issue Sep 6, 2021 · 7 comments
Open

Security issue: SMIME signature verification is still broken #216

tk-innoq opened this issue Sep 6, 2021 · 7 comments
Labels
blocked Work on the issue is blocked by something enhancement New feature or request

Comments

@tk-innoq
Copy link

tk-innoq commented Sep 6, 2021

ProtonMail is still breaking email headers as already described in:

Expected Behavior

ProtonMail should by no means alter any contents/headers of incoming mails from a third party.

Current Behavior

ProtonMail changes the Mime-Type of a signed message:

Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="--
vs.
Content-Type: multipart/mixed; boundary=

Message integrity cannot verified any more.

Possible Solution

Do not touch mail headers or content of signed messages.

Steps to Reproduce

Send a SMIME signed mail to a ProtonMail account.

Version Information

ProtonMail 4.0.5 and ProtonMailBridge still do not work.

@jwflory
Copy link

jwflory commented Oct 27, 2021

Hi, I ran into an issue with S/MIME signatures and wanted to confirm if it was related to this issue.

When I send an email from Thunderbird via the Bridge, the email body appears as an attached text file in Office 365 mail clients:

Screenshot of an email in Outlook (Office 365) showing an empty email with a text file attached

Screenshot of the text file attachment in previous image.

When I send mail from mail.protonmail.com, the email renders correctly:

Screenshot of an email in Outlook (Office 365) rendering correctly in the body content of the email, not as an attachment.

Is this related or should I open a new bug?

@andrzejsza
Copy link

please open a new bug @jwflory - the first issue reported here is known but what you are describing is not. we'll look into different request sent from webclient and bridge to try and unravel this.

@jwflory
Copy link

jwflory commented Oct 28, 2021

@andrzejsza Acknowledged, I opened #230 for my issue.

@LBeernaertProton
Copy link
Collaborator

@tk-innoq is this still an issue for you with the latest version of Bridge?

@LBeernaertProton LBeernaertProton added the question Further information is requested label Apr 14, 2023
@Neustradamus
Copy link

To follow this ticket

@tk-innoq
Copy link
Author

tk-innoq commented Nov 17, 2023

@LBeernaertProton After two years I checked it again with Bridge Version 3.6.1. The issue is still the same as described in the ticket.

@LBeernaertProton
Copy link
Collaborator

After some investigation, it seems we currently can't correctly support this in the proton API. We will internally evaluate how to best proceed to support this use case, but we can't promise any ETA at this point.

@LBeernaertProton LBeernaertProton added enhancement New feature or request blocked Work on the issue is blocked by something and removed question Further information is requested labels Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Work on the issue is blocked by something enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants