Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotating device results in search field collapsing #1379

Closed
5 of 15 tasks
dnicolson opened this issue Jun 15, 2020 · 3 comments · Fixed by #1750
Closed
5 of 15 tasks

Rotating device results in search field collapsing #1379

dnicolson opened this issue Jun 15, 2020 · 3 comments · Fixed by #1750
Assignees
Labels
bug something broken that needs fixing, confirmed and reproduceable

Comments

@dnicolson
Copy link
Contributor

The search field collapses after the device is rotated to landscape and back to portrait.

Expected:

The search field to remain the same.

Actual:

The search field now contains no placeholder text and the height is reduced.

Reproduce:

  1. Rotate device to landscape
  2. Rotate the device back to portrait

Before:
Screen Shot 2020-06-15 at 20 34 14

After:
Screen Shot 2020-06-15 at 20 34 20

APP VERSION

  • 1.5 beta
  • 1.4

APP SOURCE

  • Provenance-Emu GitHub  (Official)
  • Other  (Unofficial)

INSTALLED BY

PLATFORM

  • iPhone
  • iPad
  • Apple TV

iOS/tvOS VERSION

  • 13.x
  • 12.x
  • 11.x
  • 10.x
  • 9.x
  • 8.x

🚫 We DO NOT support unofficial builds installed from 3rd-party sites. (Official Install)
Need help or have a suggestion? Join our Official Discord

@dnicolson dnicolson added the bug something broken that needs fixing, confirmed and reproduceable label Jun 15, 2020
@dnicolson dnicolson reopened this Jul 25, 2020
@JoeMatt JoeMatt closed this as completed Aug 12, 2021
@JoeMatt JoeMatt added this to the 2.0 milestone Aug 12, 2021
@JoeMatt JoeMatt reopened this Aug 12, 2021
@JoeMatt JoeMatt modified the milestones: 2.0, v2.x / Later… Aug 12, 2021
@JoeMatt JoeMatt self-assigned this Aug 12, 2021
@JoeMatt
Copy link
Member

JoeMatt commented Feb 10, 2022

new ui in #1750

@JoeMatt JoeMatt closed this as completed Feb 10, 2022
@JoeMatt JoeMatt linked a pull request Feb 10, 2022 that will close this issue
@dnicolson
Copy link
Contributor Author

Unfortunately, the issue doesn't seem to be fixed in https://github.com/Provenance-Emu/Provenance/tree/release/2.1.0 (aa475e0):

Screen Shot 2022-02-12 at 20 11 22

@dnicolson
Copy link
Contributor Author

Changing the navigationItem.hidesSearchBarWhenScrolling value to false appears to resolve the issue, but then the search bar is always visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken that needs fixing, confirmed and reproduceable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants