Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:ret spec not being instrumented #16

Open
thiru opened this issue Jun 12, 2022 · 5 comments
Open

:ret spec not being instrumented #16

thiru opened this issue Jun 12, 2022 · 5 comments

Comments

@thiru
Copy link

thiru commented Jun 12, 2022

I followed along with your example in the readme and everything is working as expected except that the :ret spec for my-inc isn't being instrumented. s/*compile-asserts* is true and the :args spec is instrumenting correctly.

@kennyjwilli
Copy link
Member

Hi @thiru. You're correct - that's the expected behavior now. I opted to simplify this library's behavior (and thus maintainability) in #9 by removing the validity checking code. It now uses the built-in instrument checking & throwing behavior. Since Spec does not check :ret with instrument, this library does not either. However, we do support Orchestra. If you have that on the classpath, you will get :ret checking since we prefer orchestra, if available.

@thiru
Copy link
Author

thiru commented Jun 13, 2022

I see, yeah that's totally understandable. But maybe it's worth adding a note in the readme? As it is I suppose others may get confused as I did.

@thiru
Copy link
Author

thiru commented Jun 18, 2022

Happy to submit a PR with a proposed changed if you'd be open to it?

@kennyjwilli
Copy link
Member

That'd be great, thanks!

@thiru
Copy link
Author

thiru commented Jun 26, 2022

Just added a simple note to the readme: #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants