Newznab - Wrong Parsing logic for id's (OMG) non-standard IDs

[Fotguedes]

Is there an existing issue for this?

• I have searched the existing open and closed issues

Current Behavior

I'm having the same problem that sysmoon14 had in #656

This item from OMG via Prowlarr look like this:

<newznab:attr name="category" value="5000" />
<newznab:attr name="category" value="5040" />
<newznab:attr name="rageid" value="0" />
<newznab:attr name="tvdbid" value="0" />
<newznab:attr name="imdb" value="0000000" />
<newznab:attr name="tmdbid" value="0" />
<newznab:attr name="traktid" value="0" />

but the same item direct from OMG API returns:

<newznab:attr name="category" value="5000"/>
<newznab:attr name="category" value="5040"/>
<newznab:attr name="tvmaze" value="55350"/>
<newznab:attr name="tvdb" value="402910"/>

I guess because OMG don't use the attr name as "tvdbid" it is no able to parse.

Expected Behavior

Prowlarr be able to parse the expected ID's

Steps To Reproduce

No response

Environment

- OS: Linux
- Prowlarr: 1.0.0.2171
- Docker Install: No
- Using Reverse Proxy: No

What branch are you running?

Develop

Trace Logs?

None

AB#4556

[bakerboy448]

Spec is https://newznab.readthedocs.io/en/latest/misc/api/#list-of-attributes

• imdb
• rageid

code is

Prowlarr/src/NzbDrone.Core/Indexers/Definitions/Newznab/NewznabRssParser.cs

Line 105 in 29e7cc0

releaseInfo.TvdbId = GetIntAttribute(item, "tvdbid");

need to treat tvdb as tvdbid...probably should do similar for the various other names.

also interesting to see what other sites look like

[bakerboy448]

Starrs

Sonarr Newznab IDs

• tvdbid
• rageid

Radarr Newznab IDs

• imdb

Indexers

OMG

Default attributes:
* language   -> Language of the NZB (Defaults to english if unknown) 
* category   -> Category of the NZB - show twice for general and specific category
* size   -> Size of the NZB in Bytes
* coverurl   -> Link to coverurl (if it exists)

Extended attributes:
* group   -> Group the NZB was posted to
* imdb   -> IMDB id of the NZB (if it exists)
* tvmaze   -> TVMaze id of the NZB (if it exists)
* rageid   -> TVRage id of the NZB (if it exists)
* tvdb   -> TVDB id of the NZB (if it exists)
* info   -> Link to nfo file (if it exists)
* usenetdate   -> Time the NZB was posted to usenet
* guid   -> ID of the NZB on the site
* grabs   -> Number of downloads so far
* haspretime   -> Shows if the NZB has a pretime
* nuked   -> Shows if the NZB is nuked (0 or 1)
* nukereason   -> Shows the nuked reason (only if nuked = 1)
* password   -> Shows the password of the release (if the release has a password)

short name

Extended Attributes
Using the attrs tag and a comma separated list of supported values, extended information can be returned in the search results. 
For example ?attrs=files,poster,group. Note that not every attribute is available for every release type. Below is a list of some of the supported attributes. To return all known attributes per release use the parameter ?extended=1. See the API specification for a full list.

files
poster
group
team
grabs
password
comments
usenetdate
info
year
season
episode
rageid
tvmazeid
tvdbid
tvtitle
tvairdate
video
audio
resolution
framerate
language
subs
imdb
imdbscore
imdbtitle
imdbtagline
imdbplot
imdbyear
imdbdirector
imdbactors
genre
artist
album
publisher
tracks
coverurl
backdropcoverurl
review

[Qstick]

Yea, I think OMG is just off from standard on their attributes... I'll add some parsing for them, but it's clearly wrong comparing to others.